Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Trim tags on adding or editing #50083

Merged
merged 1 commit into from
Jan 22, 2025
Merged

fix: Trim tags on adding or editing #50083

merged 1 commit into from
Jan 22, 2025

Conversation

Koc
Copy link
Contributor

@Koc Koc commented Jan 7, 2025

Summary

It is possible create multiple tags with leading/trailing slashes: bar, bar, bar , etc. This confuses users and causes usage of wrong tags. Let's trim input.

Checklist

@Koc
Copy link
Contributor Author

Koc commented Jan 8, 2025

Failed tests looks unrelated

@Koc Koc force-pushed the bugfix/trim-tags branch 2 times, most recently from f414551 to 7f35000 Compare January 13, 2025 15:08
Signed-off-by: Kostiantyn Miakshyn <[email protected]>
@Koc Koc force-pushed the bugfix/trim-tags branch from 7f35000 to faa7cb7 Compare January 20, 2025 18:12
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general ok, but I am not a fan of the backend doing other things than I did on the fronend.
So maybe we should already show this / handle this correctly on the fronend.

@susnux susnux requested review from a team, icewind1991, Altahrim, sorbaugh and provokateurin and removed request for a team and icewind1991 January 22, 2025 13:35
@susnux susnux added this to the Nextcloud 31 milestone Jan 22, 2025
@Koc
Copy link
Contributor Author

Koc commented Jan 22, 2025

@susnux but solution on BE side will work for any api client

@susnux
Copy link
Contributor

susnux commented Jan 22, 2025

but solution on BE side will work for any api client

Yes so it should be done here but would be great to see it also in the frontend

@susnux susnux merged commit cddcbd1 into master Jan 22, 2025
189 checks passed
@susnux susnux deleted the bugfix/trim-tags branch January 22, 2025 17:11
@Koc
Copy link
Contributor Author

Koc commented Jan 23, 2025

/backport to stable30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants