-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Trim tags on adding or editing #50083
Conversation
Failed tests looks unrelated |
f414551
to
7f35000
Compare
Signed-off-by: Kostiantyn Miakshyn <[email protected]>
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general ok, but I am not a fan of the backend doing other things than I did on the fronend.
So maybe we should already show this / handle this correctly on the fronend.
@susnux but solution on BE side will work for any api client |
Yes so it should be done here but would be great to see it also in the frontend |
/backport to stable30 |
Summary
It is possible create multiple tags with leading/trailing slashes:
bar
,bar
,bar
, etc. This confuses users and causes usage of wrong tags. Let's trim input.Checklist